[jon at jons.org: FW: Possible bug in mode propigation?]

[Lee H]

Hey,

This landed in my inbox, the calls in sjoin to remove the ban list dont
check whether we're actually keeping our modes or not, which is probably
whats causing the bug.

----- Forwarded message from Jon Christopherson <jon at jons.org> -----

From: Jon Christopherson <jon at jons.org>
To: jclow at csupomona.edu
Cc: lee at leeh.co.uk
Subject: FW: Possible bug in mode propigation? 
Date: Tue, 11 May 2004 12:24:28 -0600

	Forwarded to you as the normal bug submitting mechanism no longer
works.

	Regards,

	Jon Christopherson


-----Original Message-----
From: Jon Christopherson [mailto:jon at jons.org] 
Sent: Sunday, May 09, 2004 4:18 PM
To: 'ircd-hybrid at the-project.org'
Subject: Possible bug in mode propigation?


Hello,

	I have noticed strange behavior between servers when syncing modes
on a channel upon a server<->server burst.

	Here is the topology I used to test:

	<Server A - irc.east.vile.com> ----> <server B - hub.vile.com> --->
rest of network

	Server A was restarted. Client A (myself) was local to Server B and
was present before the split. There were also numerous other clients on same
channels as Client A, but located on Server A. Server A splits/restarts and
reconnects, dumping all its users. I notice as servers A and B sync that
Server A which had a newer channel TS for all channels , due to all the
rejoining clients, caused Server B to loose all its invite and ban
exceptions, as can be seen below from Server B:

[15:48] * irc.east.vile.com sets mode: -e *!jon at foo.net
[15:48] * irc.east.vile.com sets mode: -I Expy!*@*


	Now even though Server B had a older channel TS, and replaced the
newer channel TS on Server A, Server A was able to send its older invalid
modes(or lack of them) and affect server B and all servers behind server B.
When looking at the ban end invite exception lists on Server A after the
sync, it appears as though Server B sent its exception modes out to Server
A. So we are now left with a desynch, where the newly introduced server A is
the only server on the network eith the correct I/e modes. This might also
be valid for bans as well, though I haven't checked.

	On another note: the 004 numeric has a few modes that are no longer
present in the ircd.

	Regards,

	Jon Christopherson
	 
PS - Version being used is:

	hybrid-7-CURRENT(20040508_0). irc.east.vile.com eGIKMpZ6 TS6ow
-
WALLCHOPS KNOCK EXCEPTS INVEX MODES=4 MAXCHANNELS=50 MAXBANS=100
MAXTARGETS=7 NICKLEN=30 TOPICLEN=384 KICKLEN=384 are supported by this
server
CHANTYPES=#& PREFIX=(ov)@+ CHANMODES=eIb,k,l,imnpst NETWORK=Vile
CASEMAPPING=rfc1459 CALLERID SAFELIST are supported by this server




----- End forwarded message -----

-- 
Lee H