etrace bugs

[Lee H]

Hi,

Some bugs in ETRACE.  First is youve completely missed out the host
parameter from the reply which comes before the IP -- which misses the point
of ETRACE.

Secondly:

  if (parc > 0)
  {
    tname = parv[1];
    if (tname != NULL)
      wilds = strchr(tname, '*') || strchr(tname, '?');
    else
      tname = "*";
  }
  else
  {
    do_all = 1;
    tname = "*";
  }

Its impossible for the else to trip -- parc is *always* at least 1 as parv[0]
is always sptr->name.  So /quote etrace is true for parc > 0, yet parv[1] is
NULL and you dont then set do_all = 1;.

You need something like:

  if(parc > 1)
  {
    tname = parv[1];
    wilds = strchr(tname, '*') || strchr(tname, '?');
  }
  else
  {
    do_all = 1;
    tname = "*";
  }

-- 
-                 Lee H // anfl
-        I code, therefore I break things.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.ircd-hybrid.org/pipermail/hybrid/attachments/20051018/b279baa5/attachment.pgp>